Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add stories for chat header #437

Merged
merged 11 commits into from
Dec 10, 2024
Merged

test: add stories for chat header #437

merged 11 commits into from
Dec 10, 2024

Conversation

codeincontext
Copy link
Collaborator

Description

  • Add stories for the "chat" header - the header shown when using Aila
  • Fix story height for the main header which is also position:fixed

@vercel Vercel
Copy link

vercel bot commented Dec 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 10:09am

@codeincontext codeincontext marked this pull request as draft December 9, 2024 20:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024 •
edited
Loading

Playwright test results

passed  15 passed
skipped  1 skipped

Details

report  Open report ↗︎
stats  16 tests across 15 suites
duration  2 minutes, 7 seconds
commit  f3076ca

Skipped tests

No persona › tests/auth.test.ts › authenticate through Clerk UI

@codeincontext codeincontext force-pushed the test/chat-header-stories branch from b5860a9 to d787b53 Compare December 9, 2024 20:36
@codeincontext codeincontext changed the base branch from main to test/chromatic-responsive December 9, 2024 20:40
@codeincontext codeincontext force-pushed the test/chat-header-stories branch 2 times, most recently from 887c1b8 to e28ded0 Compare December 9, 2024 22:36
@codeincontext codeincontext force-pushed the test/chat-header-stories branch 2 times, most recently from 2476370 to c4128c2 Compare December 9, 2024 23:13
@codeincontext codeincontext marked this pull request as ready for review December 9, 2024 23:18
@codeincontext codeincontext force-pushed the test/chat-header-stories branch from c4128c2 to 23cdb2d Compare December 9, 2024 23:23
Base automatically changed from test/chromatic-responsive to main December 10, 2024 10:01
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codeincontext codeincontext requested review from mantagen and a team December 10, 2024 11:04
mantagen
mantagen approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@mantagen mantagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codeincontext codeincontext merged commit 53fc941 into main Dec 10, 2024
21 checks passed
@codeincontext codeincontext deleted the test/chat-header-stories branch December 10, 2024 11:55
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.18.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@mikeritson-oak mikeritson-oak mentioned this pull request Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantagen mantagen mantagen approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codeincontext @oak-machine-user @mantagen